Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the no_repo_verify parameter logic in the _init_repo method by removing conditional logic and always setting it to True.
Key Changes:
- Removed the conditional assignment of
no_repo_verifybased onrepo_urlorrepo_revconfiguration - Changed the
no_repo_verifyparameter to always beTruewhen callingRepoLibrary.init()
Comments suppressed due to low confidence (1)
src/sc/clone/cloners/repo_cloner.py:30
- The documentation for
no_repo_verifyinRepoClonerConfigindicates it should be set to true when using a customrepo_url, but this parameter is not actually exposed as a configurable field in the Pydantic model (line 42 showsverify: boolbut nono_repo_verifyfield). With the code now always passingno_repo_verify = True, this documentation is misleading and should either be updated to reflect the actual behavior or the field should be added to the config if it needs to be user-configurable.
no_repo_verify (bool): Stops repo checking the validity of the version of repo
used. Should be set to true if using a custom repo_url.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BenjiMilan
force-pushed
the
feature/BWDO-522_always_no_repo_verify
branch
from
f7e9b65 to
d6379f7
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BenjiMilan
force-pushed
the
feature/BWDO-522_always_no_repo_verify
branch
from
d6379f7 to
760c3cd
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| cloner_config.manifest = cli_overrides.get("manifest") | ||
|
|
||
| if cli_overrides.get("verify"): | ||
| logger.info("Option [--verify]: Run repo hooks without verification") |
There was a problem hiding this comment.
The log message is misleading. Based on the code context and CLI help text, the --verify option runs post-sync hooks WITHOUT prompts (i.e., automatically), not 'without verification'. The message should say 'Run repo hooks without prompts' to match the CLI help text in clone_cli.py.
| logger.info("Option [--verify]: Run repo hooks without verification") | |
| logger.info("Option [--verify]: Run repo hooks without prompts") |
…dkcentral/sc into feature/BWDO-522_always_no_repo_verify
BenjiMilan
force-pushed
the
feature/BWDO-522_always_no_repo_verify
branch
from
760c3cd to
7cd115e
Compare
2 participants
Currently we have sc clone add --no-repo-verify if you provide repo_url or repo_rev. However with our current setup even without either of these we need --no-repo-verify as our repo entrypoint applies them anyway. Therefore we need to always apply no-repo-verify